Skip to content

Conversation

@ospencer
Copy link
Member

@ospencer ospencer commented Mar 1, 2025

@ospencer ospencer self-assigned this Mar 1, 2025
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the binaryen changes the content of this pr looks good to me.

@ospencer ospencer force-pushed the oscar/118 branch 2 times, most recently from 19d08c7 to b63a42f Compare October 30, 2025 16:21
@ospencer ospencer marked this pull request as ready for review October 31, 2025 02:13
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Note:
We are not planning to, but if we are merging this into main, we should probably use the local esy package.

Opam ci still needs to pass after the releases are merged as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants